Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untangle Zarf connect command #2716

Open
AustinAbro321 opened this issue Jul 11, 2024 · 0 comments
Open

Untangle Zarf connect command #2716

AustinAbro321 opened this issue Jul 11, 2024 · 0 comments
Labels
enhancement ✨ New feature or request

Comments

@AustinAbro321
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The Zarf connect command is confusing because flags can be set that conflict with the arguments.

For example, zarf connect doom --name=dbz --remote-port=9001 --type=svc --namespace=other-world is a valid command even if the service labeled with zarf.dev/connect-name: doom has nothing to do with the flags given because the options are ignored when a target is given after zarf connect.

Zarf connect should still have these flags, for now as to not cause a breaking change, but they should be deprecated and hidden.

Zarf should introduce a new command zarf connect resource and it should have required flags name, namespace and remote-port. As well as an optional flags type which defaults to svc and local-port which defaults to a random available port.

Describe the solution you'd like

  • Given I have a svc called doom in the dos-games namespace serving on port 8000
  • When I run zarf connect resource --name doom --namespace dos-games --remote-port 8000
  • Then my browser is opened to a random local port on my local machine.
@AustinAbro321 AustinAbro321 added the enhancement ✨ New feature or request label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant