Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev deploy with ###ZARF_REGISTRY### values in helm chart #2713

Open
mjnagel opened this issue Jul 10, 2024 · 1 comment
Open

dev deploy with ###ZARF_REGISTRY### values in helm chart #2713

mjnagel opened this issue Jul 10, 2024 · 1 comment
Labels
enhancement ✨ New feature or request good first issue 🥇 Good for newcomers

Comments

@mjnagel
Copy link
Contributor

mjnagel commented Jul 10, 2024

Is your feature request related to a problem? Please describe.

zarf dev deploy is useful for fast developer iterations on a package, leveraging "yolo" mode. However if a package uses the ###ZARF_REGISTRY### variable in its helm chart values a dev deploy will result in errors on the image name. While this is not often used, it is occasionally beneficial in some packages and probably should be supported in dev deploy.

Describe the solution you'd like

When I dev deploy a package Zarf should check the values files for ###ZARF_REGISTRY###. If present that should be modified to the registry for a matching image from the zarf.yaml list of images. This is the most "magical" solution.

Describe alternatives you've considered

  1. Zarf could provide a CLI flag to set a specific registry to swap for ###ZARF_REGISTRY### at dev deploy time. This would generally work well, but would not support the case of multiple ###ZARF_REGISTRY### usages tied to different registries.
  2. Zarf could provide a separate field in the zarf.yaml schema for "devDeployValues" that would override other values files. This would cover all cases, but put more responsibility on the end user to handle the dev deploy scenario.
  3. Zarf could provide CLI flag(s) and/or prompt the end user to fill in the image registry for each instance of ###ZARF_REGISTRY### identified in values.

Additional context

This is not a common scenario, but in uds-core we use the ###ZARF_REGISTRY### var to ensure that Istio proxy images are available in some edge cases.

@mjnagel mjnagel added the enhancement ✨ New feature or request label Jul 10, 2024
@AustinAbro321 AustinAbro321 added the good first issue 🥇 Good for newcomers label Jul 11, 2024
@AustinAbro321
Copy link
Contributor

I think this is reasonable to do, and we do something similar with zarf dev find-images --registry-url flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request good first issue 🥇 Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants