Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zarf fails to remove namespace label zarf.dev/agent=ignore when adopting a namespace causing package deployment to fail #2693

Open
Ansible-man opened this issue Jul 3, 2024 · 2 comments · Fixed by #2699
Labels
bug 🐞 Something isn't working

Comments

@Ansible-man
Copy link

Ansible-man commented Jul 3, 2024

Environment

Device and OS: RHEL 9
App version: 0.35.0
Kubernetes distro being used: v1.28.10 rke2
Other:

Steps to reproduce

  1. Deploy an application with helm
  2. Zarf init the cluster
  3. Deploy a zarf package with --adopt-existing-resources flag

Expected result

  1. zarf will remove the zarf.dev/agent=ignore namespace label
  2. zarf will add the app.kubernetes.io/managed-by=zarf namespace label
  3. The zarf package will deploy and the mutating webhook will point everything towards my custom private registry specified in the zarf-init command

Actual Result

  1. Zarf adds the app.kubernetes.io/managed-by=zarf namespace label
  2. zarf does not remove the zarf.dev/agent=ignore namespace label
  3. The zarf package fails to deploy because the cluster is looking for a resource located on the internet such as docker.io

Visual Proof (screenshots, videos, text, etc)

Unable 

Severity/Priority###

medium

Additional Context

Workaround is to remove the ignore label manually before adopting the namespace. This might be related to https://github.com/defenseunicorns/zarf/pull/2494/commits

@phillebaba
Copy link
Member

I have reproduced this and you are right about the change causing the issue. Should be an easy fix. Thank you for the report.

@phillebaba
Copy link
Member

We need to revert this due to this breaking other things.

#2711

@phillebaba phillebaba reopened this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants