refactor: remove use of os.Chdir #2683
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2683 +/- ##
==========================================
+ Coverage 19.16% 19.19% +0.02%
==========================================
Files 170 170
Lines 12131 12109 -22
==========================================
- Hits 2325 2324 -1
+ Misses 9523 9502 -21
Partials 283 283 ☔ View full report in Codecov by Sentry. |
|
I realize that packager needs to be refactored before we can do this. There are too many struct properties being used as function parameters which makes tracing down paths more difficult than it should be. |
|
This is probably my favorite PR of yours so far |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes use of os.Chdir from exported code.
Related Issue
Fixes #2682
Checklist before merging