Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context needs to be better passed through to several parts of Zarf so that interrupts can be implemented properly #2594

Open
AustinAbro321 opened this issue Jun 6, 2024 · 0 comments
Open

Context needs to be better passed through to several parts of Zarf so that interrupts can be implemented properly #2594

AustinAbro321 opened this issue Jun 6, 2024 · 0 comments
Labels
tech-debt 💳 Debt that the team has charged and needs to repay

Comments

@AustinAbro321
Copy link
Contributor

Many parts of Zarf do not properly handle context properly. Since #2567 was merged in ctrl-c may not interrupt as a user would expect in several situations.
At least

  • pulling doesn't get interrupted
  • During waits on deploy rather than exiting the Zarf binary interrupting exits just the current wait
  • Interrupts work on-create actions, but give a message failed after 0 retries rather than package creation canceled
@AustinAbro321 AustinAbro321 added the tech-debt 💳 Debt that the team has charged and needs to repay label Jun 6, 2024
This was referenced Jun 7, 2024
Merged
Merged
AustinAbro321 pushed a commit that referenced this issue Jun 7, 2024
@phillebaba
fix: change so that second SIGINT signal immediately exits program (#…
7ad3e53 
…2598)

## Description

This changes the behavior so that the second SIGINT signal immediately
exits. This is useful if a process is not quitting in context cancel or
if it is taking too long to quit.

## Related Issue

Relates to #2594 

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed
lucasrod16 pushed a commit that referenced this issue Jun 7, 2024
@phillebaba @AustinAbro321
refactor: add context in packager (#2597)
68a3869 
## Description

This change adds contexts to packager functions to enable them to be
cancelled.

## Related Issue

Relates to #2594

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
This was referenced Jun 11, 2024
Closed
Closed
AustinAbro321 pushed a commit that referenced this issue Jul 23, 2024
@phillebaba @AustinAbro321
fix: change so that second SIGINT signal immediately exits program (#…
7fc6f42 
…2598)

## Description

This changes the behavior so that the second SIGINT signal immediately
exits. This is useful if a process is not quitting in context cancel or
if it is taking too long to quit.

## Related Issue

Relates to #2594

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321 added a commit that referenced this issue Jul 23, 2024
@phillebaba @AustinAbro321
refactor: add context in packager (#2597)
c9dfa99 
## Description

This change adds contexts to packager functions to enable them to be
cancelled.

## Related Issue

Relates to #2594

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt 💳 Debt that the team has charged and needs to repay
Projects
Zarf
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AustinAbro321