Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up ctx.TODO -> ctx.Background #2592

Closed
schristoff-du opened this issue Jun 6, 2024 · 4 comments
Closed

clean up ctx.TODO -> ctx.Background #2592

schristoff-du opened this issue Jun 6, 2024 · 4 comments
Labels
good first issue 🥇 Good for newcomers tech-debt 💳 Debt that the team has charged and needs to repay

Comments

@schristoff-du
Copy link
Contributor

Describe what should be investigated or refactored

We currently have a context.TODO() in 26 places in the code, these should be looked at to see if they should be a context.Background() or if we can update these functions to take in contexts and use existing context.
@schristoff-du schristoff-du added good first issue 🥇 Good for newcomers tech-debt 💳 Debt that the team has charged and needs to repay labels Jun 6, 2024
@phillebaba
Copy link
Member

Related to #2594

@phillebaba phillebaba mentioned this issue Jun 11, 2024
Closed
@ujjwal405
Copy link

can i work on this issue?

@sshiv5768
Copy link

HI @phillebaba I want to work on this issue, can you asign me this issue.

@phillebaba
Copy link
Member

Closing in favor of #2365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue 🥇 Good for newcomers tech-debt 💳 Debt that the team has charged and needs to repay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@phillebaba @sshiv5768 @ujjwal405 @schristoff-du