Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore places to add more unit tests to library code #1750

Closed
Tracked by #2512
Racer159 opened this issue May 24, 2023 · 1 comment
Closed
Tracked by #2512

Explore places to add more unit tests to library code #1750

Racer159 opened this issue May 24, 2023 · 1 comment
Labels
ga Issues tracking toward Zarf 1.0 tech-debt 💳 Debt that the team has charged and needs to repay
Milestone

Comments

@Racer159
Copy link
Contributor

Describe what should be investigated or refactored

We should look at targeted areas to add unit tests (specifically in src/pkg) to provide better assurances over the interfaces in this code.

Links to any relevant code

https://github.com/defenseunicorns/zarf/tree/main/src/pkg

Additional context

This is something we should look at as we move toward GA and get Zarf's interfaces (both schema and library code) to be more stable.

@Racer159 Racer159 added tech-debt 💳 Debt that the team has charged and needs to repay ga Issues tracking toward Zarf 1.0 labels May 24, 2023
@Racer159 Racer159 added this to the The Bucket milestone Jul 27, 2023
Racer159 pushed a commit that referenced this issue Aug 10, 2023
## Description

- Replaces use of the concrete `*kubernetes.Clientset` implementation
with the `kubernetes.Interface` for client operations for easier
mocking/testing

- Adds unit test for `validatePackageArchitecture()` method

## Related Issue

Relates to #1750

## Type of change

- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed
@schristoff-du
Copy link
Contributor

Closing as a dupe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ga Issues tracking toward Zarf 1.0 tech-debt 💳 Debt that the team has charged and needs to repay
Projects
None yet
Development

No branches or pull requests

2 participants