Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flashing float column #2165

Open
devinrsmith opened this issue Jul 21, 2024 · 7 comments
Open

Flashing float column #2165

devinrsmith opened this issue Jul 21, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@devinrsmith
Copy link
Member

I noticed a situation on a server-sorted table where the text colors on a float column of near zero values was flashing as I moved my mouse over the float column; the viewport was not being scrolled. I added a custom column via UI, XStr = Float.toString(X) to see more detail on the floating point values. It looks like the difference between the yellow text and the green text is due to a small positive value (ie, green text represents a positive value) - so that explains why the text is a different color, but it doesn't explain why the color was flashing from between the colors. With the addition of the custom column, notice that that custom column also disappears during the flashing behavior. I didn't screen record my mouse movements, but it consistent of moving up and down across the range of X values; stopping the mouse movement stopped the flashing behavior.

Screencast.from.2024-07-21.10-31-39.mp4

After recording the video, I tried to reproduce the behavior, but was unable to - this video is the only evidence I have.

Here is the server side code, where I was specifically testing out large server-side sorts (takes about 90s to run, although hopefully any reproducer would be able to use much smaller size; TBD).

import io.deephaven.engine.util.TableTools
import java.util.Random

random = new Random(31337L)

x = TableTools.emptyTable(1L << 29).select("X=random.nextFloat()")

xSorted = x.sort("X")

Engine Version: 0.36.0-SNAPSHOT
Web UI Version: 0.86.1
Java Version: 22.0.2
Barrage Version: 0.6.0
Browser Name: Firefox 128
OS Name: Linux

@devinrsmith devinrsmith added bug Something isn't working triage Issue requires triage labels Jul 21, 2024
@devinrsmith
Copy link
Member Author

Here's another very similar issue. Any slight mouse movement caused this big flashing behavior.

Screencast.from.2024-07-22.15-16-36.mp4

@devinrsmith
Copy link
Member Author

Note: I was able to reproduce this without a proxy as well (just trying to eliminate variables).

@vbabich vbabich added this to the August 2024 milestone Jul 24, 2024
@vbabich vbabich added the question Further information is requested label Jul 24, 2024
@vbabich
Copy link
Collaborator

vbabich commented Jul 24, 2024

@devinrsmith is there a reproducer for the second issue?

@devinrsmith
Copy link
Member Author

The triggering conditions were very similar to #2139; ie, a lot of random fast clicks in the UI. In this case though, the proxy was removed. It's possible it's the same underlying issue, just manifesting a bit differently when in the presence or not of a proxy. I suspect some sort of race somewhere causing some sort of issue.

@vbabich
Copy link
Collaborator

vbabich commented Jul 30, 2024

@AkshatJawne can you see if you can reproduce this?

@vbabich vbabich removed question Further information is requested triage Issue requires triage labels Jul 30, 2024
@AkshatJawne
Copy link
Contributor

Tried reproducing, I could not reproduce @vbabich

@mofojed mofojed modified the milestones: August 2024, September 2024 Sep 3, 2024
@devinrsmith
Copy link
Member Author

Here's a similar looking flashing column; the table is a lastBy table (always 1 row) that was originally ticking, but now the data source has stopped so it should be unchanging.

As I move the mouse around, it seems to flash to previous versions of the table...

Screencast.from.2024-09-11.10-39-43.mp4

I'm not reliably able to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants