Allow DID parameters for verifiable credentials and presentations #1207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1201
Remove DID parameters in the
issuer
andholder
properties when looking up the identifier using the DID manager. The DID manager doesn't handle DID parameters likeversionTime
. When the DID manager is used we should be able to safely ignore them. They're only used when resolving the DID.What is being changed
Added
options
property toextractIssuer
, with optionremoveParameters
. Added aremoveDIDParameters
function to credential-utils.The
credentials-w3c
,credentials-ld
, andcredentials-jwt
plugins all remove the DID parameters before looking up the identifier via the DID manager. If the DID is resolved, the parameters are not removed.Modified
shortDid
to always remove parameters.Quality
Check all that apply:
pnpm i
,pnpm build
,pnpm test
,pnpm test:browser
locally.No tests for:
credentials-jwt
, because there are no existing testscredentials-ld
doesn't mock services, making it hard to test this feature