Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] blockchainAccountId format is outdated #152

Closed
mirceanis opened this issue Jun 2, 2022 · 2 comments
Closed

[BUG] blockchainAccountId format is outdated #152

mirceanis opened this issue Jun 2, 2022 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed released

Comments

@mirceanis
Copy link
Member

The CAIP10 format has been updated for ethereum from <address>@eip155:<chainId> to eip155:<chainId>:<address>

The DID document result must be updated to use the latest variant.

See:

ethr-did-resolver/src/resolver.ts

Line 177 in 2a66a2b

blockchainAccountId: `${currentEvent.delegate}@eip155:${chainId}`,

ethr-did-resolver/src/resolver.ts

Line 267 in 2a66a2b

blockchainAccountId: `${controller}@eip155:${chainId}`,

@mirceanis mirceanis added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jun 2, 2022
@About7Sharks
Copy link
Contributor

#153

mirceanis pushed a commit that referenced this issue Jun 4, 2022
@About7Sharks
fix: update blockchainAccountId to new CAIP10 format (#153)
31c76ae 
* use CAIP10 format.
fixes #152

* fix Tests.
mirceanis pushed a commit that referenced this issue Jun 5, 2022
@About7Sharks @mirceanis
fix: update blockchainAccountId to the new CAIP10 format (#153)
6f501b7 
* use CAIP10 format for `blockchainAccountId`.
* update tests to expect the new format.

fixes #152

BREAKING CHANGE: Apps have to update their processing of `blockchainAccountId` to use the [new CAIP10 format](https://github.com/ChainAgnostic/CAIPs/blob/master/CAIPs/caip-10.md)
uport-automation-bot pushed a commit that referenced this issue Jun 5, 2022
@semantic-release-bot
chore(release): 6.0.0 [skip ci]
e7b075e 
# [6.0.0](5.0.4...6.0.0) (2022-06-05)

### Bug Fixes

* **doc:** update LD [@context](https://github.com/context) ([#154](#154)) ([29c196a](29c196a)), closes [#151](#151)
* **doc:** update spec to use new CAIP10 format ([77a4f67](77a4f67))
* update blockchainAccountId to the new CAIP10 format ([#153](#153)) ([9c3f401](9c3f401)), closes [#152](#152)

### BREAKING CHANGES

* **doc:** Since the context definitions most often have to be embedded in apps, this requires apps to download the new definition.
* Apps have to update their processing of `blockchainAccountId` to use the [new CAIP10 format](https://github.com/ChainAgnostic/CAIPs/blob/master/CAIPs/caip-10.md)
@uport-automation-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mirceanis @About7Sharks @uport-automation-bot