Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What stack size to use for programs with CLI in icon #131

Open
deadwood2 opened this issue Feb 4, 2024 · 0 comments
Open

What stack size to use for programs with CLI in icon #131

deadwood2 opened this issue Feb 4, 2024 · 0 comments
Labels
priority:default type:bug Something isn't working
Projects

Comments

@deadwood2
Copy link
Owner

eaf88c1 (Fix for https://github.com/deadw00d2/AROS/issues/60) revealed a problem for programs without icon or with CLI tooltype. Prior that that change, stack in such situations was inherited from parent cli structure - this was in most cases Wanderer which has 262144 bytes of stack. After this change, NP_StackSize gets priority and workbench.library uses wb_DefaultStackSize as NP_StackSize in "CLI path". wb_DefaultStackSize is initialized to 40960.

Some questions:

  1. Which stack Workbench uses when running tools with CLI tooltype? One from icon? Default workebench?
  2. Prefs/Wanderer should be extended to allow editing wb_DefaultStackSize and workbench.library should adjusted to load it from prefs (check how this is done in Workbench)

What's more interesting, if the tool is used as tool for project file (via icon or deficon) and icon has CLI tooltype, the stack from icon is used on "CLI path". This means there is inconsistency between "tool" and "project" paths.

@deadwood2 deadwood2 added type:bug Something isn't working priority:default labels Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:default type:bug Something isn't working
Projects
Core
Awaiting triage
Development

No branches or pull requests

1 participant