Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Integrating with other cddl-codegen gen'd libs #208

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Docs: Integrating with other cddl-codegen gen'd libs #208

merged 4 commits into from
Aug 23, 2023

Conversation

rooooooooob
Copy link
Collaborator

@rooooooooob rooooooooob commented Aug 3, 2023 •
edited
Loading

New section with tips for generating a library that will depend on another cddl-codegen'd library e.g. CML.

Also fixes minor isues in other parts of the docs.

Also does not export the static common types if an override parameter is passed in.

@rooooooooob
Docs: Integrating with other cddl-codegen gen'd libs
d2ca9e4 
New section with tips for generating a library that will depend on
another cddl-codegen'd library e.g. CML.

Also fixes minor isues in other parts of the docs.
@rooooooooob rooooooooob added the documentation Improvements or additions to documentation label Aug 3, 2023
@rooooooooob
Copy link
Collaborator Author

Should I be including docs/yarn.lock? It results in a +/- 8000 line change which looks like it's just changing the order of some keys in a bunch of JSON maps.

@gostkin
Copy link
Contributor

gostkin commented Aug 15, 2023

looks like pub mod error is still added even if --common-import-override=cml_core is specified

gostkin
gostkin approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@gostkin gostkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gostkin gostkin merged commit 5e96387 into master Aug 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gostkin gostkin gostkin approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
Tooling team development board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rooooooooob @gostkin