Adds support for going up the CDDL AST through parent points #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastienGllmt
added
the
CDDL feature
SebastienGllmt
force-pushed
the
parent-ast
branch
from
9f2c9b4
to
2e7f72f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an example of using this, I implemented logic for a fallback for missing comment DSL names.
However, it doesn't work well because right now in the intermediate step, we can't create fresh variable names when needed as it breaks parsing in future parsing rounds :/
it seems the current solution is to have some predictable suffix index through local state and then calling
append_number_if_duplicate, but that's not possible in this case