Conway initial cml-chain update #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes cml-chain/cml-chain-wasm's structs except for the builders. Util functionality (besides builders) were updated. The builders are temporarily disabled and will be updated in a coming commit. Also needs JSON stuff moved over and clippy warnings to be fixed again.
Generated Babbage era into cml-multi-era + updated the rest of the crate to work with the changes (some types simplified to take advantage of improved cddl-codegen support, some types renames/reorganized, some types no longer in cml-chain so moved into multi-era). cml-chain builders now compile also some cml-chain files that were not added to the previous commit relating to the Conway update
Basic group encoding wasn't being preserved due to usage of _CDDL_CODEGEN_EXTERN_TYPE_ which caused the serialization code to expect a wrapping array tag that it shouldn't have. Fix: extern types that MUST be treated as basic groups should have their definition inlined, then the code deleted after (easy since we have all cml-chain extern types in a /cml-chain/ folder in the multi-era specs folder)
WASM build fixes: duplicate name between chain-wasm and multi-era-wasm which does not work when exporting to typescript. WASM build fixes: few misc things not included in previous commit lint fixes: mostly unused vars/imports/etc but also Certificate is too big which caused issues on its own + use in Result as Err variant. At some point we could offer a way to have cddl-codegen Box variants if there's a large variance and fix it that way but until then I just allow()'d it. GovAction::I6 -> GovAction::InfoAction renamed as well. this is how it should be according to the .cddl spec but cddl-codegen ignores the @name comment in this specific place: ddcSpark/cddl-codegen#211 so this was resolved by hand afterwards.
rooooooooob
force-pushed
the
conway-initial-update
branch
from
5ffd96e
to
1abd694
Compare
|
@rooooooooob pls fix the checks |
gostkin
reviewed
Sep 22, 2023
| } | ||
| // no witness as there is no single core node or genesis key that posts the certificate | ||
| Certificate::MoveInstantaneousRewardsCert(_cert) => {} | ||
| Certificate::RegCert(_cert) => todo!(), |
There was a problem hiding this comment.
will we introduce that in the following prs?
gostkin
reviewed
Sep 22, 2023
gostkin
reviewed
Sep 22, 2023
gostkin
reviewed
Sep 22, 2023
rooooooooob
force-pushed
the
conway-initial-update
branch
2 times, most recently
from
8baeee4
to
e254605
Compare
rooooooooob
force-pushed
the
conway-initial-update
branch
from
e254605
to
9f14bbb
Compare
gostkin
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes cml-chain/cml-chain-wasm's structs except for the builders.
Util functionality (besides builders) were updated.
The builders are temporarily disabled and will be updated in a coming commit.
Also needs JSON stuff moved over and clippy warnings to be fixed again.
cml-multi-era will need updating too to bring over babbage and to update existing structs (regen + update the cddls)