Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust package documentation #6366

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Adjust package documentation #6366

merged 3 commits into from
Oct 25, 2024

Conversation

jzhu13
Copy link
Contributor

@jzhu13 jzhu13 commented Oct 25, 2024

What are you changing in this pull request and why?

When the Metadata team was looking into a customer issue we noticed that their project which used a package was receiving sources from that package. After double checking the documentation it seems that packages only mention models and macros being part of package behavior, which is misleading.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@jzhu13 jzhu13 requested a review from a team as a code owner October 25, 2024 18:48
Copy link

welcome bot commented Oct 25, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@github-actions github-actions bot added the content Improvements or additions to content label Oct 25, 2024
@runleonarun runleonarun added the new contributor Label for first-time contributors label Oct 25, 2024
Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 25, 2024 9:16pm

@github-actions github-actions bot added the size: x-small This change will take under 3 hours to fix. label Oct 25, 2024
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a tech review from Joel

@runleonarun runleonarun enabled auto-merge (squash) October 25, 2024 21:06
@runleonarun runleonarun merged commit 94ae62a into current Oct 25, 2024
13 checks passed
@runleonarun runleonarun deleted the PackageDocs branch October 25, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants