Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating licenses, access, and RBAC #6310

Merged
merged 10 commits into from
Oct 18, 2024
Merged

Updating licenses, access, and RBAC #6310

merged 10 commits into from
Oct 18, 2024

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Oct 17, 2024 •
edited by github-actions bot
Loading

What are you changing in this pull request and why?

  • Updates RBAC links
  • Removes stale page
  • Updates permissions specific links (they just go to the main page anyway)
  • Cut back on the service tokens permissions list as it was inconsistent and linking to areas that don't exist. Updated to link to the permissions page at the top

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

🚀 Deployment available! Here are the direct links to the updated files:

@matthewshaver matthewshaver requested a review from a team as a code owner October 17, 2024 15:53
@vercel Vercel
Copy link

vercel bot commented Oct 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 18, 2024 2:36pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person labels Oct 17, 2024
runleonarun
runleonarun approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with two non blocking suggestions

website/docs/docs/dbt-cloud-apis/service-tokens.md Outdated Show resolved Hide resolved
website/docs/docs/dbt-cloud-apis/service-tokens.md Outdated Show resolved Hide resolved
matthewshaver and others added 2 commits October 18, 2024 10:19
@matthewshaver @runleonarun
Apply suggestions from code review
3607feb 
Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com>
@matthewshaver
Merge branch 'current' into cleanup-access
c661f2c
@matthewshaver matthewshaver enabled auto-merge (squash) October 18, 2024 14:20
@matthewshaver matthewshaver merged commit 56d7c1b into current Oct 18, 2024
7 of 8 checks passed
@matthewshaver matthewshaver deleted the cleanup-access branch October 18, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runleonarun runleonarun runleonarun approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewshaver @runleonarun