Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nfiann-prehook-emptyflag #6228

Merged
merged 26 commits into from
Oct 16, 2024
Merged

Nfiann-prehook-emptyflag #6228

merged 26 commits into from
Oct 16, 2024

Conversation

nataliefiann
Copy link
Contributor

@nataliefiann nataliefiann commented Oct 3, 2024 •
edited by github-actions bot
Loading

I've created this PR to properly capture render process for SQL compilation error and used reusable in build and pre-hook doc

What are you changing in this pull request and why?

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

🚀 Deployment available! Here are the direct links to the updated files:

@nataliefiann nataliefiann requested a review from a team as a code owner October 3, 2024 11:35
@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 16, 2024 3:02pm

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Oct 3, 2024
mirnawong1
mirnawong1 requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @nataliefiann , good job! have some suggestions on my end to keep it more concise and address the actual concept

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: medium This change will take up to a week to address labels Oct 3, 2024
mirnawong1
mirnawong1 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small sugg and approved

@nataliefiann nataliefiann merged commit faee8ff into current Oct 16, 2024
9 checks passed
@nataliefiann nataliefiann deleted the nfiann-prehook-emptyflag branch October 16, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nataliefiann @mirnawong1