auto copy header link #4411
Merged
auto copy header link #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Docs team
github-actions
bot
added
size: large
JKarlavige
reviewed
Nov 10, 2023
github-actions
bot
added
size: medium
mirnawong1
commented
Nov 13, 2023
JKarlavige
requested changes
Nov 15, 2023
There was a problem hiding this comment.
Awesome work with this @mirnawong1! Just have one requested change. I shared a loom along with a hint on what to adjust. Let me know if you have any questions and we can walk through it!
|
hey @JKarlavige thank you so much! ok i've tested this out and added another eventlistener - it looks like this world in a page refresh too. can you give it another review whenever you have a chance. thank you! |
JKarlavige
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
all lgtm! great idea and awesome work again on this @mirnawong1! it even works in the blog which is pretty cool.
|
thank you so much for your guidance and help @JKarlavige ! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a headerLinkCopy function/script that will auto copy H2 and H3 header links when header or 🔗 icon is clicked. The script also has a pop up confirming the link was auto copied and times out after 3 seconds.