Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config for semantic models #4221

Merged
merged 9 commits into from
Nov 16, 2023
Merged

config for semantic models #4221

merged 9 commits into from
Nov 16, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Oct 7, 2023 •
edited
Loading

related to: #3997

What are you changing in this pull request and why?

  • Add "Semantic models" tab for config
  • Add a "Definition" header (like other similar pages, like group, enabled, etc.)

Other

  • Added semantic models & metrics to #3957

🎩

Previews

v1.6

image

v1.7

image

Checklist

  • I have tested that the code examples work
  • I have tested that the changes look correct in the Vercel preview
  • Review the Content style guide and About versioning so my content adheres to these guidelines.

@vercel
Copy link

vercel bot commented Oct 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 3:11pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Oct 7, 2023
@dbeatty10 dbeatty10 mentioned this pull request Nov 11, 2023
Open
4 tasks
@dbeatty10 dbeatty10 marked this pull request as ready for review November 11, 2023 14:57
@dbeatty10 dbeatty10 requested a review from a team as a code owner November 11, 2023 14:57
@mirnawong1
Copy link
Contributor

hey @dbeatty10 is this pr good to review?

@dbeatty10
Copy link
Contributor Author

hey @dbeatty10 is this pr good to review?

yep, it's ready @mirnawong1 !

@dbeatty10 dbeatty10 enabled auto-merge (squash) November 13, 2023 16:49
mirnawong1
mirnawong1 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @dbeatty10 ! thank you for opening this up!

@dbeatty10 dbeatty10 merged commit 520c5a2 into current Nov 16, 2023
6 of 7 checks passed
@dbeatty10 dbeatty10 deleted the dbeatty/semantic-models-config branch November 16, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbeatty10 @mirnawong1