New materialized view adapter support #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
content
Closed
3 tasks
dataders
reviewed
Jun 22, 2023
matthewshaver
commented
Jun 28, 2023
matthewshaver
commented
Jun 28, 2023
matthewshaver
commented
Jun 28, 2023
runleonarun
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Just one small feedback comment: can you create a reusable for the example? It seems the same in all three. Here's what that would look like: https://github.com/dbt-labs/docs.getdbt.com/pull/3616/files
| - `skip` — allows runs to continue while also providing a warning that the model was skipped | ||
| - `fail` — forces runs to fail if a change is detected in a materialized view | ||
|
|
||
| You can create a materialized view by editing _one_ of these files: |
There was a problem hiding this comment.
@matthewshaver can we add line 779 - 806 into a partial (was snippet) and reuse this content for all three pages? This will help us maintain docs content and more update this section in the future. I think these lines are exactly the same, but I didn't do a diff, so 🤷🏻♀️
jtcohen6
added a commit
that referenced
this pull request
Jul 18, 2023
resolves #3696 resolves #3723 Revise v1.6 migration guide for readability. Still a handful of TODOs. ### Materialized views - Add `VersionBlock` components for adapter MVs, missed in #3593 - We seem to be missing docs on Snowflake dynamic tables. I don't know why #3494 was closed. ### Other updates - Add manifest v10 (will need addition to schemas.getdbt.com: dbt-labs/schemas.getdbt.com#24) - Add note to upgrade guide for `state:old` and `state:unmodified` (missed in #3596). I haven't done a thorough comb-through of other closed v1.6 PRs to see what needs addition to the migration guide.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Documenting support for
materialize_viewon adapters for:Bigquery
Redshift
Postgres
Checklist