Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metricflow_time_spine creation documentation to use dbt-core macro (from dbt-core PR #8616) #4124

Closed
FishtownBuildBot opened this issue Sep 25, 2023 · 0 comments · Fixed by #4263
Closed

Update metricflow_time_spine creation documentation to use dbt-core macro (from dbt-core PR #8616) #4124

FishtownBuildBot opened this issue Sep 25, 2023 · 0 comments · Fixed by #4263
Assignees
@matthewshaver
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear
Milestone
dbt Core v1.7 Doc...

Comments

@FishtownBuildBot
Copy link

FishtownBuildBot commented Sep 25, 2023 •
edited by QMalcolm
Loading

In dbt-labs/dbt-core#8616 we moved the date_spine macro from dbt-utils to dbt-core. Thus the documentation for creating the metricflow time spine should be updated to use the dbt-core built in macro instead of the dbt-utils macro
@FishtownBuildBot FishtownBuildBot mentioned this issue Sep 25, 2023
Merged
4 tasks
@runleonarun runleonarun added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt Core The changes proposed in this issue relate to dbt Core labels Sep 25, 2023
@QMalcolm QMalcolm changed the title Docs Changes Needed from dbt-core PR #8616 Update metricflow_time_spine creation documentation to use dbt-core macro (from dbt-core PR #8616) Sep 25, 2023
@matthewshaver matthewshaver self-assigned this Oct 12, 2023
@matthewshaver matthewshaver mentioned this issue Oct 12, 2023
Merged
4 tasks
matthewshaver added a commit that referenced this issue Oct 12, 2023
@matthewshaver
Time spine move from dbt-utils to dbt-core (#4263)
70d50d4 
Previews:
-
[1.6](https://docs-getdbt-com-git-time-spine-dbt-labs.vercel.app/docs/build/metricflow-time-spine?version=1.6)
-
[1.7](https://docs-getdbt-com-git-time-spine-dbt-labs.vercel.app/docs/build/metricflow-time-spine?version=1.7)

## What are you changing in this pull request and why?

Closes: #4124

Move time_spine from dbt-utils to dbt-core


Uncomment if you're publishing docs for a prerelease version of dbt
(delete if not applicable):
- [x] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)
- [x] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/guides/migration/versions)

- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
and [About
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
so my content adheres to these guidelines.
- [x] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewshaver matthewshaver

Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
dbt Core v1.7 Documentation
Development

Successfully merging a pull request may close this issue.

Time spine move from dbt-utils to dbt-core dbt-labs/docs.getdbt.com
4 participants
@runleonarun @graciegoheen @matthewshaver @FishtownBuildBot