Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a pre-release in the dbt-adapters pin to allow pre-releases to be installed on main #993

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

We are pinning dbt-adapters with only final releases, which causes pip to skip all pre-releases for dbt-adapters.

Solution

Include a lower bound using the first pre-release on PyPI, which will allows installation of pre-releases, such as 1.0.0b1.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Feb 29, 2024
@cla-bot cla-bot bot added the cla:yes label Feb 29, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@mikealfare mikealfare requested a review from a team February 29, 2024 18:35
@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Feb 29, 2024
@mikealfare mikealfare merged commit c56b9ce into main Feb 29, 2024
28 of 32 checks passed
@mikealfare mikealfare deleted the allow-dbt-adapters-pre-releases branch February 29, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants