fix spark cluster start mechanism and add extra dev requirements #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-rogers-dbt
added
Skip Changelog
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide. |
| .with_exec(["pip", "install", "-e", "."]) | ||
| ) | ||
|
|
||
| # install local test changes |
There was a problem hiding this comment.
Separating these out reduces the frequency of cache invalidation
mikealfare
reviewed
Feb 20, 2024
| if "databricks" in profile_type: | ||
| _wait_for_databricks_cluster(project) | ||
|
|
||
| yield 1 |
There was a problem hiding this comment.
Out of curiosity, why yield 1 instead of just yield?
mikealfare
approved these changes
Feb 20, 2024
|
Since we're on GHA with this now, should we remove the CircleCI Pipeline check? |
I thought we had but it seems to keep coming back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
docs dbt-labs/docs.getdbt.com/#
Problem
Solution
Checklist