Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing minimum python version up to 3.9 to match dbt-core #1122

Closed

Conversation

hiloboy0119
Copy link

@hiloboy0119 hiloboy0119 commented Oct 17, 2024

Problem

The minimum version of python for this package is set up at 3.8 where dbt-core requires 3.9

Solution

Updated all relevant files to require python 3.9 or higher

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@hiloboy0119 hiloboy0119 requested a review from a team as a code owner October 17, 2024 02:27
Copy link

cla-bot bot commented Oct 17, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Drew Goya.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Oct 17, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Drew Goya.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@hiloboy0119 hiloboy0119 marked this pull request as draft October 17, 2024 02:37
@hiloboy0119 hiloboy0119 deleted the bump_min_python_to_3_9 branch October 17, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant