Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update core install #1083

Merged
merged 4 commits into from
Jul 31, 2024
Merged

update core install #1083

merged 4 commits into from
Jul 31, 2024

Conversation

McKnight-42
Copy link
Contributor

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

The way we build testing envornmients means we are pulling in some things that 1.8.latest branch doesn't test against and causing failures.

Solution

make a common install update for dbt-core tests

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Jul 29, 2024
@McKnight-42 McKnight-42 self-assigned this Jul 29, 2024
@cla-bot cla-bot bot added the cla:yes label Jul 29, 2024
@McKnight-42 McKnight-42 changed the base branch from main to 1.8.latest July 29, 2024 18:14
@McKnight-42 McKnight-42 marked this pull request as ready for review July 29, 2024 19:12
@colin-rogers-dbt colin-rogers-dbt merged commit b98632e into 1.8.latest Jul 31, 2024
29 of 31 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the mcknight/pin_dbt_adapters_repos branch July 31, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

Assignees

@McKnight-42 McKnight-42

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@McKnight-42 @mikealfare @colin-rogers-dbt