Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix incremental python tables - dbt can't find temporary table transaction logs #1042

Merged
merged 9 commits into from
May 14, 2024
Merged

[Bug] Fix incremental python tables - dbt can't find temporary table transaction logs #1042

merged 9 commits into from
May 14, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented May 9, 2024 •
edited
Loading

resolves #1033

Problem

This test started failing. We skipped it to release and need to address the failure.

Solution

  • unskip test
  • vendor spark__make_temp_relation logic into incremental materialization

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this May 9, 2024
@cla-bot cla-bot bot added the cla:yes label May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

mikealfare
mikealfare commented May 9, 2024
View reviewed changes
requirements.txt Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns with build requirements in setup.py with all extras, i.e. pip install .[all]

@mikealfare mikealfare marked this pull request as ready for review May 13, 2024 19:59
@mikealfare mikealfare requested a review from a team as a code owner May 13, 2024 19:59
@mikealfare mikealfare marked this pull request as draft May 13, 2024 20:43
@mikealfare mikealfare changed the title unskip test [Bug] Fix incremental python tables - dbt can't find temporary table transaction logs May 13, 2024
@mikealfare mikealfare marked this pull request as ready for review May 13, 2024 22:33
@mikealfare mikealfare merged commit 629ea94 into main May 14, 2024
20 checks passed
@mikealfare mikealfare deleted the bug/1033-incremental-python-model branch May 14, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelleArk MichelleArk MichelleArk approved these changes

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes
Projects
None yet
Milestone
No milestone
3 participants
@mikealfare @MichelleArk @colin-rogers-dbt