Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new integration tests to existing framework to identify supported features #691

Merged
merged 5 commits into from
Jul 17, 2023

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Jul 15, 2023

resolves #6911

Problem

We need to enumerate the supported features for the 1.6.0rc1 release for dynamic tables.

Solution

Apply new framework integration tests to existing framework in order to identify supported features in the existing framework. Unsupported features will skip their unit tests with a message indicating why they are skipped.

Results

Supported:

  • create dynamic table
  • replace dynamic table

Unsupported:

  • creating a dynamic table in place of a table
  • creating a dynamic table in place of a view
  • creating a table in place of a dynamic table
  • creating a view in place of a dynamic table
  • update target_lag on dynamic table via alter
  • update warehouse on dynamic table via alter
  • execution of on_configuration_change config

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jul 15, 2023
@cla-bot cla-bot bot added the cla:yes label Jul 15, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@mikealfare mikealfare marked this pull request as ready for review July 15, 2023 03:33
@mikealfare mikealfare requested a review from a team as a code owner July 15, 2023 03:33
@mikealfare mikealfare merged commit b698480 into main Jul 17, 2023
24 checks passed
@mikealfare mikealfare deleted the feature/dynamic-tables/1-6-0rc1-updates branch July 17, 2023 18:22
philippe-boyd-maxa pushed a commit to maxa-ai/dbt-snowflake that referenced this pull request Nov 27, 2023
…ed features (dbt-labs#691)

* Implement integration test framework from core for dynamic tables
* Fix `target_lag` input parameter
* Identify working features and non-working features, skipped non-working feature tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants