update used gh actions ahead of set-output, node12 deprecation #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
emmyoop
requested changes
Apr 26, 2023
There was a problem hiding this comment.
This looks good.
We do need to update bot-changelog.yml as well but it's actually on me to make an update to the action we reference there to remove the deprecations. This will be true of all the core + adapter repos. I'll get that update done in the next few days and circle back to you.
Comment on lines
1
to
6
| kind: Under the Hood | ||
| body: Update version of used Github Actions | ||
| time: 2023-04-26T14:09:30.604603-05:00 | ||
| custom: | ||
| Author: davidbloss | ||
| Issue: "577" |
There was a problem hiding this comment.
You can delete this and then add the Skip Changelog label to the PR. Since these changes have 0 effect on end users, we don't need a changelog.
emmyoop
approved these changes
May 4, 2023
VersusFacit
approved these changes
May 5, 2023
emmyoop
pushed a commit
that referenced
this pull request
May 15, 2023
* update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <nssalian@users.noreply.github.com>
emmyoop
pushed a commit
that referenced
this pull request
May 15, 2023
* update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <nssalian@users.noreply.github.com> # Conflicts: # .github/workflows/release-branch-tests.yml
emmyoop
pushed a commit
that referenced
this pull request
May 15, 2023
* update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <nssalian@users.noreply.github.com> # Conflicts: # .github/workflows/main-branch-tests.yml # .github/workflows/release-branch-tests.yml
emmyoop
pushed a commit
that referenced
this pull request
May 15, 2023
* update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <nssalian@users.noreply.github.com> # Conflicts: # .github/workflows/main-branch-tests.yml # .github/workflows/release-branch-tests.yml
emmyoop
pushed a commit
that referenced
this pull request
May 15, 2023
* update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <nssalian@users.noreply.github.com> # Conflicts: # .github/workflows/main-branch-tests.yml # .github/workflows/main.yml # .github/workflows/release-branch-tests.yml
emmyoop
pushed a commit
that referenced
this pull request
May 15, 2023
* update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <nssalian@users.noreply.github.com>
emmyoop
added a commit
that referenced
this pull request
May 16, 2023
* more github deprecations fixes (#607) * more github deprecations fixes * swap out abandonded action * update used gh actions ahead of set-output, node12 deprecation (#580) * update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <nssalian@users.noreply.github.com> --------- Co-authored-by: David Bloss <david.bloss@dbtlabs.com> Co-authored-by: Neelesh Salian <nssalian@users.noreply.github.com>
emmyoop
added a commit
that referenced
this pull request
May 16, 2023
* more github deprecations fixes (#607) * more github deprecations fixes * swap out abandonded action # Conflicts: # .github/workflows/triage-labels.yml * update used gh actions ahead of set-output, node12 deprecation (#580) * update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <nssalian@users.noreply.github.com> # Conflicts: # .github/workflows/release-branch-tests.yml * Revert "more github deprecations fixes (#607)" This reverts commit 52fc588. * revert --------- Co-authored-by: David Bloss <david.bloss@dbtlabs.com>
emmyoop
added a commit
that referenced
this pull request
May 16, 2023
* more github deprecations fixes (#607) * more github deprecations fixes * swap out abandonded action # Conflicts: # .github/workflows/triage-labels.yml * update used gh actions ahead of set-output, node12 deprecation (#580) * update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <nssalian@users.noreply.github.com> # Conflicts: # .github/workflows/main-branch-tests.yml # .github/workflows/release-branch-tests.yml * Revert "more github deprecations fixes (#607)" This reverts commit 27ca3ff. --------- Co-authored-by: David Bloss <david.bloss@dbtlabs.com>
emmyoop
added a commit
that referenced
this pull request
May 16, 2023
…#612) * update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <nssalian@users.noreply.github.com> # Conflicts: # .github/workflows/main-branch-tests.yml # .github/workflows/release-branch-tests.yml Co-authored-by: David Bloss <david.bloss@dbtlabs.com>
emmyoop
added a commit
that referenced
this pull request
May 16, 2023
…#614) * update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <nssalian@users.noreply.github.com> # Conflicts: # .github/workflows/main-branch-tests.yml # .github/workflows/main.yml # .github/workflows/release-branch-tests.yml Co-authored-by: David Bloss <david.bloss@dbtlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #577 ADAP-485
Description
Update versions of used Github Actions ahead of:
node12 deprecation (Summer 2023)
set-output deprecation fully disabled on 31st May 2023)
Checklist
changie newto create a changelog entry