Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query tag back to incremental models #1212

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Oct 17, 2024

Problem

We inadvertently removed query tags on incremental models when implementing Iceberg support.

Solution

  • Add query tags back to incremental models
  • Fix the query tag test that should have caught this, but didn't

I'm skipping the changelog on this since this is a pre-regression that we caught prior to final release.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare added Skip Changelog Skips GHA to check for changelog file pre-regression Regression not yet in a stable release labels Oct 17, 2024
@mikealfare mikealfare self-assigned this Oct 17, 2024
@mikealfare mikealfare requested a review from a team as a code owner October 17, 2024 15:29
@cla-bot cla-bot bot added the cla:yes label Oct 17, 2024
"snapshots": {
"tests": {"query_tag": prefix, "post-hook": "{{ check_tag() }}"},
},
"models": {"query_tag": prefix, "post-hook": "{{ check_query_tag() }}"},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the successful runs, they warn that models.tests, seeds.tests, and snapshots.tests were unused configuration paths. In other words, the post-hook never ran. We also know that since the post-hook references a macro that does not exist; it should have referenced check_query_tag instead of check_tag.

@mikealfare
Copy link
Contributor Author

CI is failing due to the pending update for py38 retirement and the related change in branch protection rules. This should be resolved once the py38 retirement PR is merged, which contain the expected workflows.

@colin-rogers-dbt colin-rogers-dbt merged commit 8825ccb into main Oct 17, 2024
48 of 54 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the add-query-tag-back-to-incremental-models branch October 17, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes pre-regression Regression not yet in a stable release Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants