Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #8646: Support labels for semantic_models, dimensions, measures and entities #8729

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Backport #8646: Support labels for semantic_models, dimensions, measures and entities #8729

merged 1 commit into from
Sep 27, 2023

Conversation

aranke
Copy link
Member

@aranke aranke commented Sep 27, 2023

resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@aranke aranke requested a review from a team as a code owner September 27, 2023 16:39
@cla-bot cla-bot bot added the cla:yes label Sep 27, 2023
@aranke aranke requested review from emmyoop and martynydbt and removed request for MichelleArk September 27, 2023 16:39
@aranke aranke merged commit 5010e87 into 1.6.latest Sep 27, 2023
98 checks passed
@aranke aranke deleted the backport-8646-to-1.6.latest branch September 27, 2023 17:41
@aranke aranke mentioned this pull request Jul 12, 2024
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martynydbt martynydbt martynydbt approved these changes

@emmyoop emmyoop Awaiting requested review from emmyoop

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aranke @martynydbt @emmyoop