-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Behavior flags should take the default value when the project file is not loaded #338
Open
mikealfare
wants to merge
2
commits into
main
Choose a base branch
from
fix-behavior-to-always-have-flags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Fixes | ||
body: Always make behavior flags available for evaluation | ||
time: 2024-10-24T15:45:18.114936-04:00 | ||
custom: | ||
Author: mikealfare | ||
Issue: "338" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
from types import SimpleNamespace | ||
from typing import Any, Dict, List | ||
|
||
from dbt_common.behavior_flags import BehaviorFlag | ||
from dbt_common.exceptions import DbtBaseException | ||
import pytest | ||
|
||
from dbt.adapters.contracts.connection import AdapterRequiredConfig, QueryComment | ||
|
||
from tests.unit.fixtures.credentials import CredentialsStub | ||
|
||
|
||
@pytest.fixture | ||
def flags() -> Dict[str, Any]: | ||
return { | ||
"unregistered_flag": True, | ||
"default_false_user_false_flag": False, | ||
"default_false_user_true_flag": True, | ||
"default_true_user_false_flag": False, | ||
"default_true_user_true_flag": True, | ||
} | ||
|
||
|
||
@pytest.fixture | ||
def config(flags) -> AdapterRequiredConfig: | ||
raw_config = { | ||
"credentials": CredentialsStub("test_database", "test_schema"), | ||
"profile_name": "test_profile", | ||
"target_name": "test_target", | ||
"threads": 4, | ||
"project_name": "test_project", | ||
"query_comment": QueryComment(), | ||
"cli_vars": {}, | ||
"target_path": "path/to/nowhere", | ||
"log_cache_events": False, | ||
} | ||
return SimpleNamespace(**raw_config) | ||
|
||
|
||
@pytest.fixture | ||
def behavior_flags() -> List[BehaviorFlag]: | ||
return [ | ||
{ | ||
"name": "default_false_user_false_flag", | ||
"default": False, | ||
"docs_url": "https://docs.com", | ||
}, | ||
{ | ||
"name": "default_false_user_true_flag", | ||
"default": False, | ||
"description": "This is a false flag.", | ||
}, | ||
{ | ||
"name": "default_false_user_skip_flag", | ||
"default": False, | ||
"description": "This is a true flag.", | ||
}, | ||
{ | ||
"name": "default_true_user_false_flag", | ||
"default": True, | ||
"description": "This is fake news.", | ||
}, | ||
{ | ||
"name": "default_true_user_true_flag", | ||
"default": True, | ||
"docs_url": "https://moar.docs.com", | ||
}, | ||
{ | ||
"name": "default_true_user_skip_flag", | ||
"default": True, | ||
"description": "This is a true flag.", | ||
}, | ||
] | ||
|
||
|
||
def test_register_behavior_flags(adapter): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the same test as in |
||
# make sure that users cannot add arbitrary flags to this collection | ||
with pytest.raises(DbtBaseException): | ||
assert adapter.behavior.unregistered_flag | ||
|
||
# check the values of the valid behavior flags | ||
assert not adapter.behavior.default_false_user_false_flag | ||
assert not adapter.behavior.default_false_user_true_flag | ||
assert not adapter.behavior.default_false_user_skip_flag | ||
assert adapter.behavior.default_true_user_false_flag | ||
assert adapter.behavior.default_true_user_true_flag | ||
assert adapter.behavior.default_true_user_skip_flag |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is effectively the same as swapping
[]
forflags
on line308
, but doing this reads much more cleanly.