Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract test all of crv #130

Closed
dawsbot opened this issue May 23, 2022 · 3 comments · Fixed by #167
Closed

Contract test all of crv #130

dawsbot opened this issue May 23, 2022 · 3 comments · Fixed by #167
Assignees
@shivamklr
Labels
good first issue Good for newcomers

Comments

@dawsbot
Copy link
Owner

dawsbot commented May 23, 2022

There are already Contract tests for CRV, but they only test balanceOf and total_claimed see here

The contract is deployed here and the tests in the codebase should test all the following:

image
@dawsbot dawsbot assigned dawsbot and unassigned arimgibson May 23, 2022
@dawsbot dawsbot removed their assignment Jun 4, 2022
@dawsbot dawsbot added the good first issue Good for newcomers label Jul 22, 2022
@shivamklr
Copy link
Contributor

@dawsbot I can take this up.

@dawsbot
Copy link
Owner Author

dawsbot commented Nov 1, 2022

I'd love to see it!

If you do get a PR merged, you'll get this GitPOAP too!

@dawsbot
Copy link
Owner Author

dawsbot commented Nov 1, 2022

I've assigned you now @shivamklr ✅

If you decide you cannot do this please let me know ASAP to assign to someone else 🙏

@shivamklr shivamklr mentioned this issue Nov 2, 2022
Merged
@dawsbot dawsbot mentioned this issue Nov 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivamklr shivamklr

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test/crv shivamklr/essential-eth
3 participants
@dawsbot @shivamklr @arimgibson