Async fix #6
Open
Async fix #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly capturing errors generated in awaited Promises because no Promise was returned from the async fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with unhandled rejected Promises because th primary
asyncfunction did not return a Promise. This PR adds atry...catchblock inside theasyncfunction to catch any errors generated inside an awaited Promise.It also adds a call to
QUnit.start()in situations whereQUnit.config.autostartis false... I actually recommend this being the default scenario and adding a recommendation to set this inside the QUnit test page, otherwise you can get weird scenarios (I was anyway).