Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: co-authors not cleared from message template (.gitmessage) on switch from mob to solo #89

Conversation

teezzan
Copy link
Contributor

@teezzan teezzan commented Oct 8, 2022

This PR contains the following fixes:

  • Removal of all instances where co-authors are written to ~/.gitmessage.
  • Added feature spec of mob feature.
    @davidalpert Please check it out.

@teezzan teezzan changed the title Fix/co-authors_not_cleared_from_message_template_on_switch Fix: co-authors not cleared from message template (.gitmessage) on switch from mob to solo Oct 8, 2022
@teezzan teezzan marked this pull request as ready for review October 8, 2022 19:05
@davidalpert
Copy link
Owner

this looks good and the change is along the lines I had in mind.

there is something broken in the build scripts however; the feature tests failed and the build still passed. I am looking into that and will get back to you later today.

Copy link
Owner

@davidalpert davidalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teezzan thank you for your contribution!

Your code change in 8b5c24f looks good.

I have a couple of notes about the testing and PR checks that I want us to address before merging your change:

  1. the test pattern in this repo includes both golang unit tests and also ruby/cucumber acceptance tests
  2. the unit tests pass with your code change but the acceptance tests fail since there are currently some acceptance tests around the .gitmessage file
  3. the checks in this PR didn't fail due to PR build is passing with failing steps #90 which I investigated and fixed this morning
  4. the .feature file you added here appears to be testing that the core function of adding the Co-Authored-By tag still works after your change; this behavior is already covered by many other tests so you can remove it.
    • here is an example of the kind of test I was thinking to write before making any changes, demonstrating expected behavior and failing because of this bug: test: example bug feature #92
    • note that this step and others like it in other feature files will need to be removed in order to pass with 8b5c24f

Requested changes:

  • remove features/git-mob/mob-init-persists-coauthor.feature
  • please rebase on top of bug-feature-example (from test: example bug feature #92) to pick up the PR build fixes and that example feature file demonstrating the bug
  • run all the tests locally and fix broken specs by removing all the feature expectations that ~/.gitmessage reflects the mob members

@davidalpert
Copy link
Owner

@teezzan do you think you will have time to get to the requested changes this month?

if not, I can approve this PR as-is (since the code change resolves the bug) and then resolve any failed tests as housekeeping.

@teezzan
Copy link
Contributor Author

teezzan commented Oct 23, 2022

On it, @davidalpert . Sorry for being AWOL.

@teezzan teezzan force-pushed the fix/co-authors_not_cleared_from_message_template_on_switch branch from a2fe4c8 to b272e53 Compare October 23, 2022 06:23
@davidalpert davidalpert added hacktoberfest This issue is eligible for participation in Hacktoberfest hacktoberfest-accepted This pull request has been accepted as a Hacktoberfest contribution labels Oct 24, 2022
@davidalpert davidalpert merged commit 7237c62 into davidalpert:main Oct 26, 2022
davidalpert added a commit that referenced this pull request Oct 26, 2022
PR #89 fixed bug GH-88 but resulted in broken
specs left over from when we supported the
.gitmessage approach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest This issue is eligible for participation in Hacktoberfest hacktoberfest-accepted This pull request has been accepted as a Hacktoberfest contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants