Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acryl-datahub[mongodb] > Cannot map bson.decimal128.Decimal128 type #9073

Closed
jGuzmanSan opened this issue Oct 23, 2023 · 3 comments
Closed
Labels
bug Bug report stale

Comments

@jGuzmanSan
Copy link

jGuzmanSan commented Oct 23, 2023

Describe the bug
acryl-datahub[mongodb] is not able of mapping MongoDb the type bson.decimal128.Decimal128
In the ui, columns with that type are shown with type "unknown"

To Reproduce
Ingest a mongo collection that uses the type bson.decimal128.Decimal128

Expected behavior
instead of unknown, The type is shown in the UI.

Screenshots
N/A

Desktop (please complete the following information):

  • OS: N/A
  • Browser N/A
  • Version: 0.11.0.5

Additional context
offended code: https://github.com/datahub-project/datahub/blob/master/metadata-ingestion/src/datahub/ingestion/source/mongodb.py#L115

@jGuzmanSan jGuzmanSan added the bug Bug report label Oct 23, 2023
@TonyOuyangGit
Copy link
Contributor

I've added this type support in a recent PR, you should expect to see it working once the new CLI release come out

Copy link

github-actions bot commented Dec 2, 2023

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

@github-actions github-actions bot added the stale label Dec 2, 2023
@hsheth2
Copy link
Collaborator

hsheth2 commented Dec 7, 2023

Fixed as part of #9118

@hsheth2 hsheth2 closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report stale
Projects
None yet
Development

No branches or pull requests

3 participants