Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add *.herokuapp.com to the allow origins for review apps #18

Open
mcfiredrill opened this issue Jan 7, 2021 · 5 comments
Open

add *.herokuapp.com to the allow origins for review apps #18

mcfiredrill opened this issue Jan 7, 2021 · 5 comments

Comments

@mcfiredrill
Copy link
Member

In order for the chat to work on review apps, a regex *.herokuapp.com needs to be added to the list of allowed origins:
https://github.com/datafruits/hotdog_lounge/blob/master/config/config.exs#L16

I'm not sure how or if it's possible to add a regex here however.

@mcfiredrill
Copy link
Member Author

We don't use heroku for the datafruits frontend anymore, we use netlify.

The netlify preview apps don't work with this chat server either tho, for reasons I haven't figured out yet.

@einariii
Copy link

I noticed you successfully used netlify preview apps for forum testing and development. Is this still an issue?

@mcfiredrill
Copy link
Member Author

Yes we have switched to netlify from heroku, but I believe the same problem is still happening.

See this preview app : https://deploy-preview-962--datafruitsfm.netlify.app/chat

Notice the chat is not accessible.

If we add *.netlify.app to the allowed origins list , it might solve this issue.

@einariii
Copy link

einariii commented Jan 27, 2023

will take a stab at it. my research suggests using CorsPlug will allow regex in combination with the existing url list in config.exs...but to be honest i'm not even sure if a plug is necessary here.

@einariii
Copy link

einariii commented Jan 27, 2023

also: no matter where the list is stored, should we delete the herokuapp urls while we're at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants