-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add *.herokuapp.com to the allow origins for review apps #18
Comments
We don't use heroku for the datafruits frontend anymore, we use netlify. The netlify preview apps don't work with this chat server either tho, for reasons I haven't figured out yet. |
I noticed you successfully used netlify preview apps for forum testing and development. Is this still an issue? |
Yes we have switched to netlify from heroku, but I believe the same problem is still happening. See this preview app : https://deploy-preview-962--datafruitsfm.netlify.app/chat Notice the chat is not accessible. If we add *.netlify.app to the allowed origins list , it might solve this issue. |
will take a stab at it. my research suggests using CorsPlug will allow regex in combination with the existing url list in config.exs...but to be honest i'm not even sure if a plug is necessary here. |
also: no matter where the list is stored, should we delete the herokuapp urls while we're at it? |
In order for the chat to work on review apps, a regex *.herokuapp.com needs to be added to the list of allowed origins:
https://github.com/datafruits/hotdog_lounge/blob/master/config/config.exs#L16
I'm not sure how or if it's possible to add a regex here however.
The text was updated successfully, but these errors were encountered: