Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx.from_tables fails when hyphen exists in catalog or schema name #92

Closed
siddarthrokkam opened this issue Dec 11, 2023 · 5 comments
Closed
Assignees

Comments

@siddarthrokkam
Copy link

Throws the following error

Invalid from_tables statement '{from_tables}'. Should be a string in format 'table_catalog.table_schema.table_name'. You can use '*' as wildcard."

@siddarthrokkam
Copy link
Author

@edurdevic @david-tempelmann @nfx This could be the fix

in explorer.py update regex as follow
FROM_COMPONENTS_EXPR = r"^(([0-9a-zA-Z_*-]+).([0-9a-zA-Z_*-]+).([0-9a-zA-Z_*-]+))$"

@edurdevic
Copy link
Contributor

Good catch! Thanks!
Will add it to the next release. The PR #88 fixes another part of the same issue by adding backticks to table names.

@edurdevic edurdevic self-assigned this Dec 11, 2023
@edurdevic edurdevic mentioned this issue Dec 27, 2023
@souravg-db
Copy link
Contributor

This issue is fixed with #94

@souravg-db
Copy link
Contributor

Fixed in v0.0.8

@mohammedkhu
Copy link

@souravg-db just tested this, still facing the same issue, tried as follows

  1. from_tables = "data-eng-prod-zenni-bronze.*.*"
  2. from_tables = "`data-eng-prod-zenni-bronze`.*.*"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants