Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dmvp-5026 fix rds parameters setting #18

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

mrdntgrn
Copy link
Contributor

No description provided.

Copy link

Output

Copy link

what-the-diff bot commented Aug 15, 2024

PR Summary

  • Enhancement of Pre-commit Configuration
    Updated git hooks to improve code quality checks. This includes the addition of new hooks to catch trailing whitespaces, ensuring commits adhere to standard conventions (git-conventional-commits) and establish better security in git repositories (gitleaks).

  • Upgrade of the pre-commit-terraform hook version
    To keep up with the latest improvements, the version of the pre-commit-terraform hook was updated.

  • Addition of Instructions for Enabling Git Hooks
    Now you'll find useful instructions in README.md regarding how to enable these git hooks, making it easy to implement them quickly.

  • Introduction of git-conventional-commits.json File
    This file has been added to define commit conventions and changelog configurations. This will lead to more organized, standardizing, and easily readable commit messages and changelogs.

  • Improvement in main.tf Database Parameters
    The main.tf file was updated to smoothly combine user-provided and default parameters for different database engines. This ensures a more customizable and effective database setup.

  • Implementation of Parameter Tests for MySQL
    To verify the effectiveness of the RDS module with MySQL parameters, a new test file tests/parameters-mysql/main.tf has been created.

@mrdntgrn mrdntgrn merged commit 8797616 into main Aug 15, 2024
9 checks passed
@mrdntgrn mrdntgrn deleted the DMVP-5026-fix-rds-parameters-setting branch August 15, 2024 12:22
Copy link

Output

Copy link

🎉 This PR is included in version 1.3.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants