Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add urllib3 to nightly conda builds #6102

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Conversation

jrbourbeau
Copy link
Member

In #5982 we added urllib3 as a dependency. This was added over in our conda-forge recipe, but not not to our nightly conda build recipe (which is currently failing due to ModuleNotFoundError: No module named 'urllib3'). This PR adds the new urllib3 dependency to our nightly builds

cc @charlesbluca @jakirkham

@charlesbluca
Copy link
Member

charlesbluca commented Apr 11, 2022

Thanks @jrbourbeau! Yikes sorry I missed the broken conda builds over the last ~12 days 😓

I'm a little interested in how tests passed on #5982 to begin with - I would've thought that adding urllib3 to the setup dependencies would've caused a failure on the build process, but it looks like build tests weren't running on that PR?

@jrbourbeau
Copy link
Member Author

No worries. Looks like we are missing requirements.txt from the files that will trigger a conda build on PRs. Just pushed a PR to make sure requirements.txt is included as well

@jakirkham
Copy link
Member

jakirkham commented Apr 11, 2022

Probably because we skip Conda tests unless specific files or directories are touched. Was about to suggest we include requirements.txt and setup.py to that list. Looks like James added one of those while I was typing 😉

Edit: And we already include setup.py 😄

@charlesbluca
Copy link
Member

Ah yeah - totally forgot we were restricting PR builds to certain file changes - thanks all 😄

@jakirkham has mentioned this before, but maybe it would be helpful to use load_setup_py_data in the nightly recipe to cut down on changes that need to be made when adding new dependencies? Happy to explore that in a follow up PR so we can get this unblocked now

@github-actions
Copy link
Contributor

Unit Test Results

       16 files  ±0         16 suites  ±0   7h 50m 12s ⏱️ + 14m 44s
  2 730 tests ±0    2 649 ✔️ ±0       80 💤 ±0  1 ±0 
21 725 runs  ±0  20 650 ✔️  - 1  1 074 💤 +1  1 ±0 

For more details on these failures, see this check.

Results for commit 57a739b. ± Comparison against base commit f6b2e03.

@jakirkham jakirkham merged commit 910a16e into dask:main Apr 11, 2022
@jakirkham
Copy link
Member

Thanks James! 😄

@jrbourbeau jrbourbeau deleted the fix-conda-build branch April 12, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants