Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Stimulus ID's in Scheduler with ContextVars #6046

Closed
wants to merge 33 commits into from

Conversation

sjperkins
Copy link
Member

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

Unit Test Results

       18 files  ±0         18 suites  ±0   9h 27m 19s ⏱️ + 32m 12s
  2 725 tests +1    2 643 ✔️ +  2       81 💤 ±0  1  - 1 
24 373 runs  +9  23 159 ✔️ +14  1 213 💤  - 4  1  - 1 

For more details on these failures, see this check.

Results for commit d0aa434. ± Comparison against base commit bddc3f2.

♻️ This comment has been updated with latest results.

@sjperkins
Copy link
Member Author

.take

distributed/utils_comm.py Outdated Show resolved Hide resolved
distributed/utils_comm.py Outdated Show resolved Hide resolved
distributed/scheduler.py Outdated Show resolved Hide resolved
distributed/client.py Outdated Show resolved Hide resolved
distributed/http/templates/task.html Outdated Show resolved Hide resolved
distributed/worker.py Outdated Show resolved Hide resolved
distributed/worker.py Outdated Show resolved Hide resolved
distributed/worker.py Outdated Show resolved Hide resolved
distributed/scheduler.py Show resolved Hide resolved
distributed/scheduler.py Show resolved Hide resolved
distributed/scheduler.py Show resolved Hide resolved
distributed/scheduler.py Show resolved Hide resolved
distributed/scheduler.py Show resolved Hide resolved
distributed/client.py Outdated Show resolved Hide resolved
distributed/client.py Show resolved Hide resolved
distributed/utils_comm.py Outdated Show resolved Hide resolved
@fjetter fjetter mentioned this pull request Apr 5, 2022
Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things appeared to be a bit more complex than I anticipated and I became a bit nervous of whether contextvars are the right approach. I think there should only be one global thing (I might be wrong) and I went on implementing something on top of this PR, see #6068

We should sync up and align what the next steps are

distributed/scheduler.py Outdated Show resolved Hide resolved
distributed/client.py Show resolved Hide resolved
distributed/scheduler.py Outdated Show resolved Hide resolved
distributed/scheduler.py Outdated Show resolved Hide resolved
@crusaderky
Copy link
Collaborator

I'm a bit swarmed right now and can't keep up with the review process - I'm leaving it to @fjetter

@sjperkins
Copy link
Member Author

Some things appeared to be a bit more complex than I anticipated and I became a bit nervous of whether contextvars are the right approach. I think there should only be one global thing (I might be wrong) and I went on implementing something on top of this PR, see #6068

We should sync up and align what the next steps are

I've changed the ContextVar to a single global variable, rather than a per Scheduler instance ContextVar. I don't think this changes the underlying functionality much, as the ContextVar is only used internally in the Scheduler at present. I think it would be great to to do a follow up PR that extends this to Client and Workers.

@sjperkins
Copy link
Member Author

Introduces too much indentation into the diff. Closing in favour of #6083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition tracing for scheduler task transitions
3 participants