More idiomatic mypy configuration #6022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
commented
Mar 29, 2022
| additional_dependencies: | ||
| # Type stubs | ||
| - types-docutils | ||
| - types-requests | ||
| - types-paramiko | ||
| - types-PyYAML | ||
| - types-psutil | ||
| - types-setuptools |
There was a problem hiding this comment.
Revert #6017 - this is still used by mypy to validate setup.py (you can see it by setting ignore_missing_imports = false below)
crusaderky
commented
Mar 29, 2022
gjoseph92
approved these changes
Mar 29, 2022
crusaderky
commented
Mar 30, 2022
mrocklin
pushed a commit
to mrocklin/distributed
that referenced
this pull request
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move awkward-looking command-line argument from pre-config to setup.cfg
Now it is possible to run mypy directly from the command line and obtain the same results as in pre-commit (as long as all type stubs are installed).