Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify average in timeseries titles #5974

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Specify average in timeseries titles #5974

merged 1 commit into from
Mar 22, 2022

Conversation

mrocklin
Copy link
Member

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

phobson
phobson approved these changes Mar 21, 2022
View reviewed changes
Copy link

@phobson phobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these clarifications

@mrocklin
Copy link
Member Author

cc @ncclementi if you can take a quick look

ncclementi
ncclementi approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@ncclementi ncclementi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!
Thanks for adding the clarification. I think it's very useful

@github-actions
Copy link
Contributor

Unit Test Results

       12 files  +       1         12 suites  +1   7h 35m 50s ⏱️ + 45m 28s
  2 666 tests ±       0    2 581 ✔️  -        2    80 💤  -   1  5 ❌ +3 
15 908 runs  +1 461  15 045 ✔️ +1 372  857 💤 +86  6 ❌ +3 

For more details on these failures, see this check.

Results for commit ee34462. ± Comparison against base commit 2e98ae9.

@jcrist jcrist merged commit 4866615 into dask:main Mar 22, 2022
@mrocklin mrocklin deleted the timeseries-titles branch March 22, 2022 15:32
@mrocklin
Copy link
Member Author

mrocklin commented Mar 22, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phobson phobson phobson approved these changes

@jcrist jcrist jcrist approved these changes

@ncclementi ncclementi ncclementi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrocklin @phobson @jcrist @ncclementi