Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update computation code retrieval logic #5236

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Aug 19, 2021

This PR implements the fix proposed in #5224 (comment) for when __name__ is not available. In this case, we will not attempt to retrieve the user code for a computation and will instead return "<Code not available>"

@jrbourbeau
Copy link
Member Author

jrbourbeau commented Aug 19, 2021

It looks like gpuCI is failing due to a segfault?

13:33:36 docker: Error response from daemon: OCI runtime create failed: container_linux.go:380: starting container process caused: process_linux.go:545: container init caused: Running hook #0:: error running hook: signal: segmentation fault (core dumped), stdout: , stderr:: unknown.

13:33:36 FATAL: Failed to start docker image

13:33:36 java.io.IOException: Failed to start docker image

13:33:36 	at com.gpuopenanalytics.jenkins.remotedocker.DockerState.launchContainer(DockerState.java:298)

13:33:36 	at com.gpuopenanalytics.jenkins.remotedocker.DockerState.launchContainers(DockerState.java:199)

13:33:36 	at com.gpuopenanalytics.jenkins.remotedocker.RemoteDockerBuildWrapper.setUp(RemoteDockerBuildWrapper.java:175)

13:33:36 	at hudson.model.Build$BuildExecution.doRun(Build.java:157)

13:33:36 	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:513)

13:33:36 	at hudson.model.Run.execute(Run.java:1907)

13:33:36 	at hudson.matrix.MatrixRun.run(MatrixRun.java:153)

13:33:36 	at hudson.model.ResourceController.execute(ResourceController.java:97)

13:33:36 	at hudson.model.Executor.run(Executor.java:429)

13:33:36 Recording test results

13:33:36 [Checks API] No suitable checks publisher found.

13:33:36 Finished: FAILURE

cc @quasiben @charlesbluca

EDIT: Also appearing over in #5233, so I'll assume it's unrelated to the specific changes in this PR

@charlesbluca
Copy link
Member

Yup, this definitely looks like a gpuCI related issue - I've pinged our ops team

@charlesbluca
Copy link
Member

rerun tests

1 similar comment
@pentschev
Copy link
Member

rerun tests

@pentschev
Copy link
Member

gpuCI is back and tests pass there. It seems that other failures are not related to this PR.

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @jrbourbeau !

@jrbourbeau
Copy link
Member Author

Thanks for the quick gpuCI fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants