Add backoff to client connect attempts. #3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jacobtomlinson could I ask you to take a look at this? I think that we ended up doing this repeated connection bit because of new Kubernetes addresses arriving. |
|
Ping @jacobtomlinson in case you're back on work |
|
@smurfix can you respond to #3496 (comment)? |
|
It as faster to just make changes than wait here. I've pushed to @smurfix 's branch I've also instituted a maximum delay of 1s. Merging on passed tests. |
|
This is merged in . Thank you @smurfix . Also, I notice that this is your first code contribution to this repository. Welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3487.