Unvendoring joblib #2019
Closed
Unvendoring joblib #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows scikit-learn/scikit-learn#11166 to deal with unvendoring joblib in scikit-learn
jakirkham
reviewed
Jun 7, 2018
| try: | ||
| from sklearn.externals.joblib.parallel import ( # noqa | ||
| AutoBatchingMixin, ParallelBackendBase) | ||
| except ModuleNotFoundError: |
There was a problem hiding this comment.
Guess we could add the following for Python 2/3 support
try:
ModuleNotFoundError
except NameError:
ModuleNotFoundError = ImportError
|
Should this be closed in light of PR ( #2298 )? |
|
Sure
…On Fri, Nov 2, 2018 at 11:34 PM jakirkham ***@***.***> wrote:
Should this be closed in light of PR ( #2298
<#2298> )?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2019 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASszKE6MJLc4aeoyTB2-qaklN4P02clks5urQ6tgaJpZM4UUPpV>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows scikit-learn/scikit-learn#11166 to deal with unvendoring joblib in scikit-learn