Use new dask interface #1513
Merged
Use new dask interface #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Overall this seems fine to me. This does break backwards compatibility with older versions of dask. Not sure how you feel about that. If you wanted, backwards compatibility could be maintained by defining small helper functions for getting the graph, keys, and finalizers, depending on the version of dask. |
|
I think I'm ok with a hard dependency and synchronized release. This seems big enough. |
mrocklin
force-pushed
the
dask-interface
branch
from
36c104d
to
51111bc
Compare
mrocklin
force-pushed
the
dask-interface
branch
from
763bc49
to
853acb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new dask interface created in dask/dask#2748
cc @jcrist