Skip to content

Commit

Permalink
TST/CI: Skip batched comm test win / tornado5 (#4166)
Browse files Browse the repository at this point in the history
Previously we only skipped on Python 3.6. Now we skip on any Python
version on Windows with Tornado 5.

I can reproduce the issue if people want me to look more, but I don't
think this is high priority.

Closes #4163.
  • Loading branch information
TomAugspurger authored Oct 14, 2020
1 parent 785500b commit 849650e
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions distributed/tests/test_batched.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from distributed.utils import All, TimeoutError
from distributed.utils_test import captured_logger
from distributed.protocol import to_serialize
from distributed.compatibility import WINDOWS, PY37, TORNADO6
from distributed.compatibility import WINDOWS, TORNADO6


class EchoServer:
Expand Down Expand Up @@ -258,9 +258,7 @@ async def test_serializers():


@pytest.mark.asyncio
@pytest.mark.skipif(
WINDOWS and not PY37 and not TORNADO6, reason="failing on windows, py36, tornado 5."
)
@pytest.mark.skipif(WINDOWS and not TORNADO6, reason="failing on windows, tornado 5.")
async def test_handles_exceptions():
# Ensure that we properly handle exceptions in BatchedSend.
# https://github.com/pangeo-data/pangeo/issues/788
Expand Down

0 comments on commit 849650e

Please sign in to comment.