-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove conda-forge from default install instructions #2336
Conversation
Apparently people were confused by this, and thought that Dask was only maintained on the conda-forge channel. We change installation instructions to explicitly state that Dask is available on either defaults or conda-forge. This removes the `-c conda-forge` flag from the conda install line.
Any objections to this? |
docs/source/install.rst
Outdated
To install the latest version of Dask from the | ||
`conda-forge <https://conda-forge.github.io/>`_ repository using | ||
Binary Dask packages are maintained on both the ``defaults`` and `conda-forge | ||
<https://conda-forge.github.io/>`_ channels. You can install them using | ||
`conda <https://www.continuum.io/downloads>`_:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if you want detail here, which could easily confuse... Some points:
- dask is installed by default in anaconda, but not necessarily the latest version, they they don't need to install anything
defaults
is a channel alias, I don't think you can do-c defaults
- we no longer say how to specify conda-forge, but maybe having the link is enough
- conda is almost never seen on its own, so the link maybe should go to miniconda?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've mentioned Anaconda at the start. I then immediately say that you can conda install dask. Afterwards I mention that Dask packages are maintained on conda-forge. I think that the way this is phrased it will not register much on people who don't understand channels, which is probably good because they probably don't want to use them.
* Document instructions for minmal dask-core install This pull request's core purpose is to add in instructions for installing dask-core which has less dependency bloat than the default `conda install dask`. A use-case for example is for developers building docker images that don't want a overly huge image size (see e.g. [here](https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#avoid-installing-unnecessary-packages)), or for those who would like to manage the optional dependencies themselves. Aware of #2336 which removes confusion of two channels (default and conda-forge), but seeing as dask-core downloads overwhelming come from the conda-forge channel (>30k vs < 100 see https://anaconda.org/search?q=dask-core), I thought I'd add back in the instructions for conda-forge, but add in 'recommended' in brackets next to default channel so that new users won't be too confused. Open to recommendations on what's better. External references: https://pypi.python.org/pypi/dask conda/conda#4982 (note new optional dependency functionality from conda 4.4.0 onwards) conda-forge/dask-feedstock#22 * Retain only link to conda-forge Remove `conda install -c conda-forge` so as to not add extra confusion, as per #2336. Using KISS philosophy. * Fix up some more small style and english issues.
Apparently people were confused by this, and thought that Dask was only
maintained on the conda-forge channel. We change installation
instructions to explicitly state that Dask is available on either
defaults or conda-forge. This removes the
-c conda-forge
flag fromthe conda install line.