Remove conda-forge from default install instructions #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently people were confused by this, and thought that Dask was only maintained on the conda-forge channel. We change installation instructions to explicitly state that Dask is available on either defaults or conda-forge. This removes the `-c conda-forge` flag from the conda install line.
|
Any objections to this? |
docs/source/install.rst
Outdated
| To install the latest version of Dask from the | ||
| `conda-forge <https://conda-forge.github.io/>`_ repository using | ||
| Binary Dask packages are maintained on both the ``defaults`` and `conda-forge | ||
| <https://conda-forge.github.io/>`_ channels. You can install them using | ||
| `conda <https://www.continuum.io/downloads>`_:: |
There was a problem hiding this comment.
I don't know if you want detail here, which could easily confuse... Some points:
- dask is installed by default in anaconda, but not necessarily the latest version, they they don't need to install anything
defaultsis a channel alias, I don't think you can do-c defaults- we no longer say how to specify conda-forge, but maybe having the link is enough
- conda is almost never seen on its own, so the link maybe should go to miniconda?
There was a problem hiding this comment.
OK, I've mentioned Anaconda at the start. I then immediately say that you can conda install dask. Afterwards I mention that Dask packages are maintained on conda-forge. I think that the way this is phrased it will not register much on people who don't understand channels, which is probably good because they probably don't want to use them.
3 tasks
mrocklin
pushed a commit
that referenced
this pull request
Nov 18, 2017
* Document instructions for minmal dask-core install This pull request's core purpose is to add in instructions for installing dask-core which has less dependency bloat than the default `conda install dask`. A use-case for example is for developers building docker images that don't want a overly huge image size (see e.g. [here](https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#avoid-installing-unnecessary-packages)), or for those who would like to manage the optional dependencies themselves. Aware of #2336 which removes confusion of two channels (default and conda-forge), but seeing as dask-core downloads overwhelming come from the conda-forge channel (>30k vs < 100 see https://anaconda.org/search?q=dask-core), I thought I'd add back in the instructions for conda-forge, but add in 'recommended' in brackets next to default channel so that new users won't be too confused. Open to recommendations on what's better. External references: https://pypi.python.org/pypi/dask conda/conda#4982 (note new optional dependency functionality from conda 4.4.0 onwards) conda-forge/dask-feedstock#22 * Retain only link to conda-forge Remove `conda install -c conda-forge` so as to not add extra confusion, as per #2336. Using KISS philosophy. * Fix up some more small style and english issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently people were confused by this, and thought that Dask was only
maintained on the conda-forge channel. We change installation
instructions to explicitly state that Dask is available on either
defaults or conda-forge. This removes the
-c conda-forgeflag fromthe conda install line.