Miscellaneous joblib updates #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As joblib contains the needed functionality here and has done so for a while, go ahead and import from joblib directly instead of scikit-learn's vendored joblib, which will soon be removed.
This just generates an `ImportError` as of distributed 1.24.0.
This just propagates an `ImportError` as of distributed 1.24.0.
|
Thanks. I have a few CI things to clean up. Will get to this soon. |
|
No worries. Came across this in some other work I was doing. |
|
Not sure why the doc build is failing, while it's passing on examples.dask.org. Will have to look later. |
|
Thanks John! |
stsievert
pushed a commit
to stsievert/dask-ml
that referenced
this pull request
Oct 29, 2019
* Use joblib directly in benchmark As joblib contains the needed functionality here and has done so for a while, go ahead and import from joblib directly instead of scikit-learn's vendored joblib, which will soon be removed. * Drop import of `distributed.joblib` This just generates an `ImportError` as of distributed 1.24.0. * Drop import of `dask_ml.joblib` This just propagates an `ImportError` as of distributed 1.24.0.
stsievert
pushed a commit
to stsievert/dask-ml
that referenced
this pull request
Nov 1, 2019
* Use joblib directly in benchmark As joblib contains the needed functionality here and has done so for a while, go ahead and import from joblib directly instead of scikit-learn's vendored joblib, which will soon be removed. * Drop import of `distributed.joblib` This just generates an `ImportError` as of distributed 1.24.0. * Drop import of `dask_ml.joblib` This just propagates an `ImportError` as of distributed 1.24.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As PR ( joblib/joblib#722 ) added the Distributed backend to Joblib in 0.12.2 and scikit-learn 0.20.0 vendored that joblib version with PR ( scikit-learn/scikit-learn#11741 ), reasonably recent versions of joblib and scikit-learn are already sufficient for our needs here. There may be more room for cleanup following this.
Edit: Also worth noting Distributed 1.24.0 has been raising an
ImportErrorwhen importingdistributed.joblib( dask/distributed#2298 ). As we require Distributed 1.25.0 as of PR ( #466 ), we've also been raising that sameImportErrorfor a while. So it's probably safe to drop thedask_ml.joblibshim as well.