-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing: distributed
not installed with [dev]
extras_require
#463
Conversation
Adding distributed to the dev dependencies sounds best.
…On Mon, Feb 18, 2019 at 7:10 PM Nathan Henrie ***@***.***> wrote:
Hello,
I just followed the contributing guide
<https://ml.dask.org/contributing.html#building-dask-ml>, which
recommends a sensible python -m pip install -e ".[dev]", but
unfortunately my first step was to ensure that existing tests pass before
making any changes, and pytest tests/ raised an ImportError that I assume
is related to dask.distributed.
ImportError while loading conftest '/home/n8henrie/git/dask-ml/tests/conftest.py'.tests/conftest.py:7: in <module>
from distributed.utils_test import cluster
E ModuleNotFoundError: No module named 'distributed'
I was able to work around by also installing .[complete] (though in
retrospect it looks like I could have just installed distributed alone, I
thought there could be a handful of missing dependencies that I'd have to
discover one by one, so I went with complete to make sure it was taken
care of in a single install).
It seems like the recommended setup in the contributing guide should lead
to a point where one can at least run the tests -- I recommend either a
change to the contributing guide to additionally recommend a manual
installation of this dependency (in a quick glance I didn't see how to add
a PR to the page), or possibly by adding distributed to the dev
dependencies, or by including the complete dependencies to the dev
dependencies.
Happy to make this (super minor) change into a PR if one of these is
thought to be a best course of action.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#463>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIqo3_psSezKO2--zaDqFWwy4AMErks5vO07_gaJpZM4bB9ji>
.
|
Perhaps we could update |
I think either sounds reasonable. For reference: the current |
Based on #466 (comment), we're going to keep |
Sorry for they run-around here, but I think that |
@TomAugspurger Are you sure that's the right PR? I don't see any changes to the |
I think @TomAugspurger meant #466. |
Gotcha, thanks! |
Hello,
I just followed the contributing guide, which recommends a sensible
python -m pip install -e ".[dev]"
, but unfortunately my first step was to ensure that existing tests pass before making any changes, andpytest tests/
raised anImportError
that I assume is related todask.distributed
.I was able to work around by also installing
.[complete]
(though in retrospect it looks like I could have just installeddistributed
alone, I thought there could be a handful of missing dependencies that I'd have to discover one by one, so I went withcomplete
to make sure it was taken care of in a single install).It seems like the recommended setup in the contributing guide should lead to a point where one can at least run the tests -- I recommend either a change to the contributing guide to additionally recommend a manual installation of this dependency (in a quick glance I didn't see how to add a PR to the page), or possibly by adding
distributed
to the dev dependencies, or by including thecomplete
dependencies to thedev
dependencies.Happy to make this (super minor) change into a PR if one of these is thought to be a best course of action.